Improve documentation for default language #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
changed the title
brianjlowe
reviewed
Dec 12, 2024
There was a problem hiding this comment.
This is maybe a bit longer and more complicated than it needs to be. I would suggest something like the following:
A comma-separated ordered list of locales to be offered to the user in the language-selector dropdown at the top of the VIVO UI. The order of items here controls the order of options in the language selector. The first locale in the list will be used as a default until the user selects another. Each included locale must be supported by VIVO i18n .properties or .ttl files.
brianjlowe
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue: 4026
What does this pull request do?
Improve documentation about default language.
What's new?
example.runtime.properties, a comment above languages.selectableLocales property has been updated.
How should this be tested?
Read the text in the comment, and check whether it is easy to understand and aligned with the implementation.
Interested parties
Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises: